joeCarf commented on code in PR #7460: URL: https://github.com/apache/rocketmq/pull/7460#discussion_r1359144932
########## broker/src/main/java/org/apache/rocketmq/broker/client/ProducerManager.java: ########## @@ -212,34 +207,34 @@ public Channel getAvailableChannel(String groupId) { List<Channel> channelList; ConcurrentHashMap<Channel, ClientChannelInfo> channelClientChannelInfoHashMap = groupChannelTable.get(groupId); if (channelClientChannelInfoHashMap != null) { + if (channelClientChannelInfoHashMap.size() == 0) { Review Comment: will it be better using `MapUtils.isEmpty()` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org