lizhimins commented on code in PR #7120:
URL: https://github.com/apache/rocketmq/pull/7120#discussion_r1357842136
##########
tieredstore/src/main/java/org/apache/rocketmq/tieredstore/TieredMessageStore.java:
##########
@@ -392,7 +396,7 @@ public void destroy() {
}
@Override
- public int cleanUnusedTopic(Set<String> retainTopics) {
+ public int cleanUnusedTopic(Set<String> retainTopics) throws
RocksDBException {
Review Comment:
这里不建议改接口，元数据的存储可以有多种实现，比如默认的 json 就不会有 rocksdb exception
##########
tieredstore/src/main/java/org/apache/rocketmq/tieredstore/TieredMessageStore.java:
##########
@@ -392,7 +396,7 @@ public void destroy() {
}
@Override
- public int cleanUnusedTopic(Set<String> retainTopics) {
+ public int cleanUnusedTopic(Set<String> retainTopics) throws
RocksDBException {
Review Comment:
这里不建议改接口，元数据的存储可以有多种实现，比如默认的 json 就不会有 rocksdb exception
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
