caigy commented on code in PR #181:
URL: https://github.com/apache/rocketmq-operator/pull/181#discussion_r1333932321
##########
example/rocketmq_v1alpha1_rocketmq_cluster.yaml:
##########
@@ -163,6 +163,28 @@ spec:
spec:
containers:
- name: console
+ env:
+ - name: ROCKETMQ_CONFIG_LOGINREQUIRED
+ value: "true"
Review Comment:
If login is required by default, you'd better also update the document.
##########
example/rocketmq_v1alpha1_rocketmq_cluster.yaml:
##########
@@ -163,6 +163,28 @@ spec:
spec:
containers:
- name: console
+ env:
+ - name: ROCKETMQ_CONFIG_LOGINREQUIRED
+ value: "true"
image: apacherocketmq/rocketmq-console:2.0.0
ports:
- - containerPort: 8080
\ No newline at end of file
+ - containerPort: 8080
+ volumeMounts:
+ - name: console-config
+ mountPath: /tmp/rocketmq-console/data
Review Comment:
It seems a bit curious to place the configuration files under `/tmp`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
