[GitHub] [rocketmq] wash1983 opened a new issue, #7383: [Bug] plain acl can not update topicpermit to null

[via GitHub]

wash1983 opened a new issue, #7383:
URL: https://github.com/apache/rocketmq/issues/7383

   ### Before Creating the Bug Report
   
   - [X] I found a bug, not just asking a question, which should be created in 
[GitHub Discussions](https://github.com/apache/rocketmq/discussions).
   
   - [X] I have searched the [GitHub 
Issues](https://github.com/apache/rocketmq/issues) and [GitHub 
Discussions](https://github.com/apache/rocketmq/discussions)  of this 
repository and believe that this is not a duplicate.
   
   - [X] I have confirmed that this bug belongs to the current repository, not 
other repositories of RocketMQ.
   
   
   ### Runtime platform environment
   
   all
   
   ### RocketMQ version
   
   4.9.7
   
   ### JDK Version
   
   _No response_
   
   ### Describe the Bug
   
   adminext 调用createAndUpdatePlainAccessConfig 时如果要设置topicpermit 或grouppermit 
为空，只能传入null否则报格式错误。
   但是null时 是无法更新的， 结果就是保留已有值，经排查问题出在
   
org.apache.rocketmq.acl.plain.PlainPermissionManager.createAclAccessConfigMap(Map<String,
 Object>, PlainAccessConfig) 的433行
   
    if (plainAccessConfig.getTopicPerms() != null) {
               newAccountsMap.put(AclConstants.CONFIG_TOPIC_PERMS, 
plainAccessConfig.getTopicPerms());
           }
           if (plainAccessConfig.getGroupPerms() != null) {
               newAccountsMap.put(AclConstants.CONFIG_GROUP_PERMS, 
plainAccessConfig.getGroupPerms());
           }
   将判空去掉即可。希望改进
   
   ### Steps to Reproduce
   
   a
   
   ### What Did You Expect to See?
   
   a
   
   ### What Did You See Instead?
   
   先删除，再新增
   
   ### Additional Context
   
   _No response_


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org