drpmma commented on PR #7257: URL: https://github.com/apache/rocketmq/pull/7257#issuecomment-1698443172
> It seems that it is not appropriate to create retry topic in PopMessageProcessor. > > For the background, the retry topic will be created when heartbeat request is sent to broker for the remoting protocol client. > > https://github.com/apache/rocketmq/blob/b3acee77d0a76fffba808d7b303b15fec7eb700f/broker/src/main/java/org/apache/rocketmq/broker/processor/ClientManageProcessor.java#L183-L185 > > But for the gRPC Local mode, it will not invoke createTopicInSendMessageBackMethod so that the retry topic will not be created. > > https://github.com/apache/rocketmq/blob/b3acee77d0a76fffba808d7b303b15fec7eb700f/proxy/src/main/java/org/apache/rocketmq/proxy/grpc/v2/client/ClientActivity.java#L109-L114 > > Maybe it's better to handle creating retry topic behavior in heartbeat while taking proxy mode into consideration. But for the cluster mode, the heartbeat only has group information and doesn't know what the specific broker to create the retry topic. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
