RongtongJin commented on code in PR #7276:
URL: https://github.com/apache/rocketmq/pull/7276#discussion_r1306950290
##########
common/src/main/java/org/apache/rocketmq/common/config/AbstractRocksDBStorage.java:
##########
@@ -386,7 +386,9 @@ public synchronized boolean shutdown() {
}
//4. close db.
if (db != null) {
- this.db.syncWal();
+ if (!this.readOnly) {
+ this.db.syncWal();
+ }
Review Comment:
It would be better to integrate two if statements into one
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
