RapperCL commented on PR #7268: URL: https://github.com/apache/rocketmq/pull/7268#issuecomment-1694913352
> IMO, the `timeoutMillis` stands for the time-limit, there should be timeoutException only when time-limit is above 0; if the time limit is 0, it is not a timeout. So i think the original way has no problem However, in the current context semantics, timeout represents the remaining time of the current operation. Moreover, the underlying timeout time is usually mandatory and should not be less than 0, unless in higher application layers, we can set it as follows: when the timeout is less than 0, we set a default timeout time. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
