joeCarf commented on code in PR #7259:
URL: https://github.com/apache/rocketmq/pull/7259#discussion_r1305611637
##########
client/src/main/java/org/apache/rocketmq/client/impl/factory/MQClientInstance.java:
##########
@@ -147,7 +147,7 @@ public MQClientInstance(ClientConfig clientConfig, int
instanceIndex, String cli
this.mQClientAPIImpl = new MQClientAPIImpl(this.nettyClientConfig,
clientRemotingProcessor, rpcHook, clientConfig);
if (this.clientConfig.getNamesrvAddr() != null) {
-
this.mQClientAPIImpl.updateNameServerAddressList(this.clientConfig.getNamesrvAddr());
+ this.mQClientAPIImpl.updateNameServerAddr(null);
Review Comment:
could you please explain the logic here?
##########
client/src/main/java/org/apache/rocketmq/client/impl/mqclient/MQClientAPIExt.java:
##########
@@ -99,7 +99,7 @@ public MQClientAPIExt(
public boolean updateNameServerAddressList() {
if (this.clientConfig.getNamesrvAddr() != null) {
-
this.updateNameServerAddressList(this.clientConfig.getNamesrvAddr());
+ this.updateNameServerAddr(null);
Review Comment:
why remove this？
##########
client/src/main/java/org/apache/rocketmq/client/impl/mqclient/MQClientAPIExt.java:
##########
@@ -99,7 +99,7 @@ public MQClientAPIExt(
public boolean updateNameServerAddressList() {
if (this.clientConfig.getNamesrvAddr() != null) {
-
this.updateNameServerAddressList(this.clientConfig.getNamesrvAddr());
+ this.updateNameServerAddr(null);
Review Comment:
why remove this？
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
