joeCarf commented on code in PR #7238:
URL: https://github.com/apache/rocketmq/pull/7238#discussion_r1305541496
##########
proxy/src/main/java/org/apache/rocketmq/proxy/grpc/v2/channel/GrpcClientChannel.java:
##########
@@ -210,7 +211,7 @@ protected CompletableFuture<Void>
processCheckTransaction(CheckTransactionStateR
protected CompletableFuture<Void>
processGetConsumerRunningInfo(RemotingCommand command,
GetConsumerRunningInfoRequestHeader header,
CompletableFuture<ProxyRelayResult<ConsumerRunningInfo>>
responseFuture) {
- if (!header.isJstackEnable()) {
+ if (Objects.isNull(header) || !header.isJstackEnable()) {
Review Comment:
can you explain why should this func just return when `header` is null?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
