kang-hl commented on code in PR #7188:
URL: https://github.com/apache/rocketmq/pull/7188#discussion_r1303722823
##########
namesrv/src/main/java/org/apache/rocketmq/namesrv/routeinfo/RouteInfoManager.java:
##########
@@ -171,7 +171,7 @@ public void deleteTopic(final String topic, final String
clusterName) {
this.lock.writeLock().lockInterruptibly();
//get all the brokerNames fot the specified cluster
Set<String> brokerNames = this.clusterAddrTable.get(clusterName);
- if (brokerNames == null || brokerNames.isEmpty()) {
+ if (brokerNames == null) {
Review Comment:
if (nameSet.isEmpty()) {
this.clusterAddrTable.remove(clusterName);
log.info("unregisterBroker, remove cluster from clusterAddrTable {}",
clusterName);
}
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
