drpmma commented on code in PR #7200:
URL: https://github.com/apache/rocketmq/pull/7200#discussion_r1302368780
##########
proxy/src/main/java/org/apache/rocketmq/proxy/service/message/LocalRemotingCommand.java:
##########
@@ -17,15 +17,18 @@
package org.apache.rocketmq.proxy.service.message;
import java.util.HashMap;
+import org.apache.rocketmq.proxy.common.ProxyContext;
import org.apache.rocketmq.remoting.CommandCustomHeader;
import org.apache.rocketmq.remoting.exception.RemotingCommandException;
+import org.apache.rocketmq.remoting.protocol.LanguageCode;
import org.apache.rocketmq.remoting.protocol.RemotingCommand;
public class LocalRemotingCommand extends RemotingCommand {
- public static LocalRemotingCommand createRequestCommand(int code,
CommandCustomHeader customHeader) {
+ public static LocalRemotingCommand createRequestCommand(int code,
CommandCustomHeader customHeader, ProxyContext ctx) {
Review Comment:
It's better to pass language rather than proxyContext into the constructor
of LocalRemotingCommand.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
