lizhanhui commented on code in PR #7065:
URL: https://github.com/apache/rocketmq/pull/7065#discussion_r1277120196
##########
broker/src/main/java/org/apache/rocketmq/broker/controller/ReplicasManager.java:
##########
@@ -225,7 +225,7 @@ public void shutdown() {
public synchronized void changeBrokerRole(final Long newMasterBrokerId,
final String newMasterAddress,
final Integer newMasterEpoch,
- final Integer syncStateSetEpoch, final Set<Long> syncStateSet) {
+ final Integer syncStateSetEpoch, final Set<Long> syncStateSet) throws
Exception {
Review Comment:
`Exception` is too general...Create one within the project exception
hierarchy
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
