lizhimins commented on code in PR #7030:
URL: https://github.com/apache/rocketmq/pull/7030#discussion_r1266157335
##########
broker/src/main/java/org/apache/rocketmq/broker/processor/PopMessageProcessor.java:
##########
@@ -589,8 +589,8 @@ private CompletableFuture<Long> popMsgFromQueue(String
attemptId, boolean isRetr
atomicRestNum.set(result.getMaxOffset() -
result.getNextBeginOffset() + atomicRestNum.get());
String brokerName =
brokerController.getBrokerConfig().getBrokerName();
for (SelectMappedBufferResult mapedBuffer :
result.getMessageMapedList()) {
- // We should not recode buffer for normal topic message
- if (!isRetry) {
+ // We should not recode buffer when
popResponseReturnActualRetryTopic is true or topic is not retry topic
+ if
(brokerController.getBrokerConfig().isPopResponseReturnActualRetryTopic() ||
!isRetry) {
Review Comment:
不对吧，默认是 false，全走下面了
##########
broker/src/main/java/org/apache/rocketmq/broker/processor/PopMessageProcessor.java:
##########
@@ -589,8 +589,8 @@ private CompletableFuture<Long> popMsgFromQueue(String
attemptId, boolean isRetr
atomicRestNum.set(result.getMaxOffset() -
result.getNextBeginOffset() + atomicRestNum.get());
String brokerName =
brokerController.getBrokerConfig().getBrokerName();
for (SelectMappedBufferResult mapedBuffer :
result.getMessageMapedList()) {
- // We should not recode buffer for normal topic message
- if (!isRetry) {
+ // We should not recode buffer when
popResponseReturnActualRetryTopic is true or topic is not retry topic
+ if
(brokerController.getBrokerConfig().isPopResponseReturnActualRetryTopic() ||
!isRetry) {
Review Comment:
不对吧，默认是 false，全走下面了
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
