dingshuangxi888 commented on code in PR #6958:
URL: https://github.com/apache/rocketmq/pull/6958#discussion_r1246349115


##########
pom.xml:
##########
@@ -888,6 +888,11 @@
                     </exclusion>
                 </exclusions>
             </dependency>
+            <dependency>
+                <groupId>io.github.aliyunmq</groupId>
+                <artifactId>rocketmq-grpc-netty-codec-haproxy</artifactId>
+                <version>1.0.0</version>
+            </dependency>

Review Comment:
   The haproxy library contains 10 classes and has a lot of code. In order to 
be able to follow the upgrade of the grpc-netty version in the future, it may 
be better to introduce it by shade



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to