ferrirW commented on code in PR #6903:
URL: https://github.com/apache/rocketmq/pull/6903#discussion_r1229606960


##########
store/src/main/java/org/apache/rocketmq/store/MappedFileQueue.java:
##########
@@ -252,6 +252,12 @@ public boolean doLoad(List<File> files) {
                 continue;
             }
 
+            if (file.length() == 0) {
+                boolean ok = file.delete();

Review Comment:
   IMO, It is safer to add a judgment which ensure that it is the last file 
before deleting it



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to