Jashinck commented on code in PR #110:
URL: 
https://github.com/apache/rocketmq-eventbridge/pull/110#discussion_r1205175435


##########
adapter/runtime/src/main/java/org/apache/rocketmq/eventbridge/adapter/runtime/boot/EventBusListener.java:
##########
@@ -51,16 +55,37 @@ public EventBusListener(CirculatorContext 
circulatorContext, EventSubscriber eve
     @Override
     public void run() {
         while (!stopped) {
+            // 从任务列表中获取本次拉取的队列
+            String runnerName = circulatorContext.takeBusRunnerName();

Review Comment:
   
这地方不合理,队列中的每个runnerName在不会更新的前提下,拿完一次就没了。很明显,不符合主线程要将每个runnerName,要一直拿事件的逻辑。Transfer,
 Trigger同样不可以这么处理。



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to