aaron-ai commented on code in PR #6733:
URL: https://github.com/apache/rocketmq/pull/6733#discussion_r1190667342
##########
broker/src/main/java/org/apache/rocketmq/broker/processor/AdminBrokerProcessor.java:
##########
@@ -775,13 +775,21 @@ private synchronized RemotingCommand
updateBrokerConfig(ChannelHandlerContext ct
String bodyStr = new String(body, MixAll.DEFAULT_CHARSET);
Properties properties = MixAll.string2Properties(bodyStr);
if (properties != null) {
- LOGGER.info("updateBrokerConfig, new config: [{}] client:
{} ", properties, ctx.channel().remoteAddress());
+ LOGGER.info("updateBrokerConfig, new config: [{}] client:
{} ", properties, callerAddress);
+
+ if (properties.containsKey("brokerConfigPath")) {
+ response.setCode(ResponseCode.SYSTEM_ERROR);
Review Comment:
Is `NO_PERMISSION` better than `SYSTEM_ERROR`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
