RongtongJin commented on code in PR #6641:
URL: https://github.com/apache/rocketmq/pull/6641#discussion_r1176231728
##########
store/src/main/java/org/apache/rocketmq/store/ConsumeQueue.java:
##########
@@ -803,14 +801,37 @@ public void assignQueueOffset(QueueOffsetAssigner
queueOffsetAssigner, MessageEx
for (int i = 0; i < queues.length; i++) {
String key = queueKey(queues[i], msg);
if (messageStore.getMessageStoreConfig().isEnableLmq() &&
MixAll.isLmq(key)) {
- queueOffsets[i] = queueOffsetAssigner.assignLmqOffset(key,
(short) 1);
+ queueOffsets[i] = queueOffsetOperator.getLmqOffset(key);
}
}
MessageAccessor.putProperty(msg,
MessageConst.PROPERTY_INNER_MULTI_QUEUE_OFFSET,
StringUtils.join(queueOffsets,
MixAll.MULTI_DISPATCH_QUEUE_SPLITTER));
removeWaitStorePropertyString(msg);
}
+ @Override
+ public void increaseQueueOffset(QueueOffsetOperator queueOffsetOperator,
MessageExtBrokerInner msg,
+ short messageNum) {
+ String topicQueueKey = getTopic() + "-" + getQueueId();
+ queueOffsetOperator.increaseQueueOffset(topicQueueKey, messageNum);
+
+ // For LMQ
+ if (!messageStore.getMessageStoreConfig().isEnableMultiDispatch() ||
msg.getTopic().startsWith(MixAll.RETRY_GROUP_TOPIC_PREFIX)) {
Review Comment:
> Could you please write more comments to explain why three are some other
branches?
done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
