2011shenlin commented on code in PR #92:
URL:
https://github.com/apache/rocketmq-eventbridge/pull/92#discussion_r1174556208
##########
adapter/runtimer/src/main/java/org/apache/rocketmq/eventbridge/adapter/runtimer/boot/EventTargetPusher.java:
##########
@@ -55,17 +55,18 @@ public void run() {
this.waitForRunning(1000);
continue;
}
- if(logger.isDebugEnabled()){
+ if (logger.isDebugEnabled()) {
logger.debug("start push content by pusher - {}",
JSON.toJSONString(targetRecord));
}
ExecutorService executorService =
circulatorContext.getExecutorService(targetRecord.getExtensions().getString(RuntimerConfigDefine.TASK_CLASS));
executorService.execute(() -> {
try {
String runnerName =
targetRecord.getExtensions().getString(RuntimerConfigDefine.RUNNER_NAME);
- SinkTask sinkTask =
circulatorContext.getPusherTaskMap().get(runnerName);;
+ SinkTask sinkTask =
circulatorContext.getPusherTaskMap().get(runnerName);
sinkTask.put(Lists.newArrayList(targetRecord));
- }catch (Exception exception){
+ offsetManager.commit(targetRecord);
Review Comment:
这里是正常消费的时候，位点的管理，异常处理这块还没有加
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
