Jashinck commented on code in PR #92:
URL:
https://github.com/apache/rocketmq-eventbridge/pull/92#discussion_r1174547119
##########
adapter/runtimer/src/main/java/org/apache/rocketmq/eventbridge/adapter/runtimer/boot/EventTargetPusher.java:
##########
@@ -55,17 +55,18 @@ public void run() {
this.waitForRunning(1000);
continue;
}
- if(logger.isDebugEnabled()){
+ if (logger.isDebugEnabled()) {
logger.debug("start push content by pusher - {}",
JSON.toJSONString(targetRecord));
}
ExecutorService executorService =
circulatorContext.getExecutorService(targetRecord.getExtensions().getString(RuntimerConfigDefine.TASK_CLASS));
executorService.execute(() -> {
try {
String runnerName =
targetRecord.getExtensions().getString(RuntimerConfigDefine.RUNNER_NAME);
- SinkTask sinkTask =
circulatorContext.getPusherTaskMap().get(runnerName);;
+ SinkTask sinkTask =
circulatorContext.getPusherTaskMap().get(runnerName);
sinkTask.put(Lists.newArrayList(targetRecord));
- }catch (Exception exception){
+ offsetManager.commit(targetRecord);
Review Comment:
Pusher完了后，只有异常的位点管理，没有正常消费的位点管理？
##########
adapter/runtimer/src/main/java/org/apache/rocketmq/eventbridge/adapter/runtimer/Runtimer.java:
##########
@@ -49,30 +46,33 @@ public class Runtimer {
private CirculatorContext circulatorContext;
+ @Autowired
Review Comment:
需要Autowired么？构造方法有初始化
##########
adapter/runtimer/src/main/java/org/apache/rocketmq/eventbridge/adapter/runtimer/boot/EventRuleTransfer.java:
##########
@@ -43,17 +45,25 @@ public class EventRuleTransfer extends ServiceThread {
private static final Logger logger =
LoggerFactory.getLogger(EventRuleTransfer.class);
+ @Autowired
Review Comment:
EventRuleTransfer未进行@Component注解，下面其他注解类同
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
