aaron-ai commented on code in PR #6590:
URL: https://github.com/apache/rocketmq/pull/6590#discussion_r1168125905
##########
proxy/src/main/resources/rmq.proxy.logback.xml:
##########
@@ -229,10 +229,10 @@
<appender name="RocketmqRebalanceLockAppender_inner"
class="ch.qos.logback.core.rolling.RollingFileAppender">
- <file>${user.home}/logs/rocketmqlogs/${brokerLogDir}/lock.log</file>
+
<file>${user.home}${file.separator}logs${file.separator}rocketmqlogs${file.separator}${brokerLogDir:-${file.separator}}${file.separator}lock.log</file>
Review Comment:
If `brokerLogDir` is not set, there will be three consecutive
`${file.separator}` here. Have you tested it on multiple operating systems to
ensure that the path with three consecutive `${file.separator}` works properly?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
