caigy commented on code in PR #6538:
URL: https://github.com/apache/rocketmq/pull/6538#discussion_r1161381353
##########
broker/src/main/java/org/apache/rocketmq/broker/BrokerStartup.java:
##########
@@ -167,7 +167,6 @@ public static BrokerController
buildBrokerController(String[] args) throws Excep
System.exit(-4);
}
- messageStoreConfig.setHaListenPort(nettyServerConfig.getListenPort() +
1);
Review Comment:
IMO this PR will break the compatibility, that is, the default value of
`haLitenPort` is `listenPort + 1`. Users setting `listenPort` but not setting
`haLitenPort` explicitly will find `haLitenPort` changes after updating to new
version.
The more appropriate way may be:
- if `haLitenPort` is set explicitly, use the value set by user;
- if `haLitenPort` is not set, assign `listenPort + 1` to it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
