odbozhou commented on code in PR #460:
URL: https://github.com/apache/rocketmq-connect/pull/460#discussion_r1160502658
##########
connectors/rocketmq-replicator/src/main/java/org/apache/rocketmq/replicator/ReplicatorSourceConnector.java:
##########
@@ -208,22 +208,22 @@ public Class<? extends Task> taskClass() {
return ReplicatorSourceTask.class;
}
- private Set<String> neededParamKeys = new HashSet<String>() {
+ private Map<String, Boolean> neededParamKeys = new HashMap<String,
Boolean>() {
{
- add(ReplicatorConnectorConfig.SRC_CLOUD);
- add(ReplicatorConnectorConfig.SRC_REGION);
- add(ReplicatorConnectorConfig.SRC_CLUSTER);
- add(ReplicatorConnectorConfig.SRC_ENDPOINT);
- add(ReplicatorConnectorConfig.SRC_TOPICTAGS);
- add(ReplicatorConnectorConfig.DEST_CLOUD);
- add(ReplicatorConnectorConfig.DEST_REGION);
- add(ReplicatorConnectorConfig.DEST_CLUSTER);
- add(ReplicatorConnectorConfig.DEST_ENDPOINT);
- add(ReplicatorConnectorConfig.DEST_TOPIC);
- add(ReplicatorConnectorConfig.SRC_CLOUD);
- add(ReplicatorConnectorConfig.SRC_ACL_ENABLE);
- add(ReplicatorConnectorConfig.DEST_ACL_ENABLE);
- add(ERRORS_TOLERANCE_CONFIG);
+ put(ReplicatorConnectorConfig.SRC_CLOUD, false);
Review Comment:
In my opinion, after the connector is implemented, the necessary
configuration has been determined. In the subsequent evolution and development,
of course, it is possible to challenge the verification rules of these
parameters, but it is a very low-frequency operation. For example, we have some
differences now. However, after our discussion this time, after confirming
those that are indeed required and those that are not, there may be basically
no major changes.
I think what you said about unifying the necessary parameters is a good
idea. However, each connector implementation may have different validation
rules, not only necessary and non-essential parameters. Can you try to tidy up
some parameters though? Let's do further discussions on specific parameters?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
