caigy commented on code in PR #6254:
URL: https://github.com/apache/rocketmq/pull/6254#discussion_r1125811381
##########
broker/src/main/java/org/apache/rocketmq/broker/processor/AckMessageProcessor.java:
##########
@@ -94,16 +94,15 @@ public boolean isPopReviveServiceRunning() {
@Override
public RemotingCommand processRequest(final ChannelHandlerContext ctx,
RemotingCommand request) throws RemotingCommandException {
- return this.processRequest(ctx.channel(), request, true);
+ return this.processRequest(ctx.channel(), request);
}
@Override
public boolean rejectRequest() {
return false;
}
- private RemotingCommand processRequest(final Channel channel,
RemotingCommand request,
- boolean brokerAllowSuspend) throws RemotingCommandException {
+ private RemotingCommand processRequest(final Channel channel,
RemotingCommand request) throws RemotingCommandException {
Review Comment:
This param may be useful in the future, so pls communicate with the
community before modify it.
##########
broker/src/main/java/org/apache/rocketmq/broker/processor/AckMessageProcessor.java:
##########
@@ -160,8 +159,7 @@ private RemotingCommand processRequest(final Channel
channel, RemotingCommand re
if (requestHeader.getOffset() < oldOffset) {
return response;
}
- while
(!this.brokerController.getPopMessageProcessor().getQueueLockManager().tryLock(lockKey))
{
- }
+
Review Comment:
Could you explain the reason to remove the locking statement?
##########
broker/src/main/java/org/apache/rocketmq/broker/processor/ForwardRequestProcessor.java:
##########
@@ -1,45 +0,0 @@
-/*
Review Comment:
Have you launched a discuss about removing this class in community?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
