This is an automated email from the ASF dual-hosted git repository.

jinrongtong pushed a commit to branch develop
in repository https://gitbox.apache.org/repos/asf/rocketmq.git


The following commit(s) were added to refs/heads/develop by this push:
     new 99c980ea3 [ISSUE #6082] Simplify MQClientAPIImpl processSendResponse 
code
99c980ea3 is described below

commit 99c980ea37602b69c70b8e718bef9895f2222314
Author: hardyfish <[email protected]>
AuthorDate: Thu Feb 16 08:40:01 2023 +0800

    [ISSUE #6082] Simplify MQClientAPIImpl processSendResponse code
---
 .../java/org/apache/rocketmq/client/impl/MQClientAPIImpl.java     | 8 ++------
 1 file changed, 2 insertions(+), 6 deletions(-)

diff --git 
a/client/src/main/java/org/apache/rocketmq/client/impl/MQClientAPIImpl.java 
b/client/src/main/java/org/apache/rocketmq/client/impl/MQClientAPIImpl.java
index 8347f3653..d901f7832 100644
--- a/client/src/main/java/org/apache/rocketmq/client/impl/MQClientAPIImpl.java
+++ b/client/src/main/java/org/apache/rocketmq/client/impl/MQClientAPIImpl.java
@@ -805,16 +805,12 @@ public class MQClientAPIImpl implements 
NameServerUpdateCallback {
             responseHeader.getMsgId(), messageQueue, 
responseHeader.getQueueOffset());
         sendResult.setTransactionId(responseHeader.getTransactionId());
         String regionId = 
response.getExtFields().get(MessageConst.PROPERTY_MSG_REGION);
-        String traceOn = 
response.getExtFields().get(MessageConst.PROPERTY_TRACE_SWITCH);
         if (regionId == null || regionId.isEmpty()) {
             regionId = MixAll.DEFAULT_TRACE_REGION_ID;
         }
-        if (traceOn != null && traceOn.equals("false")) {
-            sendResult.setTraceOn(false);
-        } else {
-            sendResult.setTraceOn(true);
-        }
         sendResult.setRegionId(regionId);
+        String traceOn = 
response.getExtFields().get(MessageConst.PROPERTY_TRACE_SWITCH);
+        sendResult.setTraceOn(!Boolean.FALSE.toString().equals(traceOn));
         return sendResult;
     }
 

Reply via email to