lizhimins commented on code in PR #5976:
URL: https://github.com/apache/rocketmq/pull/5976#discussion_r1095455779
##########
tools/src/main/java/org/apache/rocketmq/tools/admin/DefaultMQAdminExtImpl.java:
##########
@@ -1658,8 +1660,14 @@ public TopicConfigSerializeWrapper
getUserTopicConfig(final String brokerAddr, f
TopicList topicList =
this.mqClientInstance.getMQClientAPIImpl().getSystemTopicListFromBroker(brokerAddr,
timeoutMillis);
Iterator<Entry<String, TopicConfig>> iterator =
topicConfigSerializeWrapper.getTopicConfigTable().entrySet().iterator();
while (iterator.hasNext()) {
- String topic = iterator.next().getKey();
- if (topicList.getTopicList().contains(topic) || !specialTopic &&
(topic.startsWith(MixAll.RETRY_GROUP_TOPIC_PREFIX) ||
topic.startsWith(MixAll.DLQ_GROUP_TOPIC_PREFIX))) {
+ TopicConfig topicConfig = iterator.next().getValue();
+ if (topicList.getTopicList().contains(topicConfig.getTopicName())
+ ||
TopicValidator.isSystemTopic(topicConfig.getTopicName())) {
+ iterator.remove();
+ } else if (!specialTopic &&
StringUtils.startsWithAny(topicConfig.getTopicName(),
+ MixAll.RETRY_GROUP_TOPIC_PREFIX,
MixAll.DLQ_GROUP_TOPIC_PREFIX)) {
+ iterator.remove();
+ } else if (!PermName.isValid(topicConfig.getPerm())) {
Review Comment:
Invalid topic 都属于系统 topic 吗?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
