aaron-ai commented on code in PR #5755:
URL: https://github.com/apache/rocketmq/pull/5755#discussion_r1055334069


##########
broker/src/main/java/org/apache/rocketmq/broker/processor/PopReviveService.java:
##########
@@ -122,7 +125,8 @@ private void reviveRetry(PopCheckPoint popCheckPoint, 
MessageExt messageExt) thr
         }
         if (putMessageResult.getAppendMessageResult() == null ||
             putMessageResult.getAppendMessageResult().getStatus() != 
AppendMessageStatus.PUT_OK) {
-            throw new Exception("reviveQueueId=" + queueId + ", revive error, 
msg is: " + msgInner);
+            POP_LOGGER.error("reviveQueueId=" + queueId + ", revive error, msg 
is: " + msgInner);

Review Comment:
   Use `{}` to print the argument.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to