zmuxuny opened a new pull request, #7385:
URL: https://github.com/apache/rocketmq-dashboard/pull/7385

   ### Which Issue(s) This PR Fixes
   
   Fixes #7166. Replaces stale-closed #7167 using its refreshed original fork 
branch, preserving authorship.
   
   ### Brief Description
   
   Replace the mouse-only custom-property removal icon in the Topic 
send-message form with a native Ant Design text button. Keep the existing 
callback and pointer behavior, add a translated numbered accessible name, and 
explicitly use htmlType="button" so Enter/Space remove the chosen row without 
submitting the form. Retained property values and eventual send payload remain 
unchanged.
   
   Diff against rocketmq-studio 7abf8ada: 3 files, +88/-2. Current sources of 
open #7163 and #5586 still leave this Topic property action as an unbuttoned 
icon; the new cases cover this distinct gap. No surrounding dialog translation 
or send API changes.
   
   ### How Did You Test This Change?
   
   Fresh November 4 checks on 1a2c40392450e584dbffe131b86421583082d1ce, with 
the original 20-second timeout and sequential local runs:
   - Complete TopicPage suite: 61/61 passed (253 seconds).
   - Focused English/Chinese Enter/Space and pointer regression coverage: 5/5 
passed, and 5/5 again after restoring the negative control.
   - Same tests against unchanged trunk production: four keyboard cases fail 
because the accessible removal button is absent; the pointer case passes.
   - TypeScript project build, full frontend ESLint, changed-file Prettier, 
diff whitespace check, and production build passed. Build license check: 134 
actual components, 141 license files.
   
   Tests verify keyboard focus, row renumbering, retained values, no accidental 
submit/send, and the final exact payload. No full frontend/backend suite or 
live-cluster run is claimed locally. Hosted CI will be tracked for this PR 
head. AI assistance was used for audit and validation.
   
   ### Checklist
   - [x] Ready for review with a focused regression and negative control.
   - [x] Original branch and authorship retained.
   - [x] No new dependencies or backend/API changes.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to