lizhimins commented on PR #7309: URL: https://github.com/apache/rocketmq-dashboard/pull/7309#issuecomment-6434005348
Closing this one. The vendor filter is welcome - that part of the change is fine. The rest runs against how the instance list deliberately works: - Studio's instance list is unpaged by design (the row count is small and operators scan it as a whole). `GET /instances/page` fetches the full list and then `subList`s it in memory, so it is pagination in name only while adding a second endpoint to keep in sync. - Dropping `withCounts` empties the count columns, which is a visible regression on every cloud-instance row. - The in-memory sorter replaces ordering the service layer already provides. Please resubmit the vendor filter on its own and we will merge it. Note also that #6697 touches the same `index.tsx`, so whichever lands second will need a rebase. The linked issue #3564 is already closed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
