[GitHub] [rocketmq] mxsm opened a new issue, #5455: [Question]MappedFileQueue#checkSelf not needs return boolean?

Wed, 02 Nov 2022 03:08:27 -0700 


mxsm opened a new issue, #5455:
URL: https://github.com/apache/rocketmq/issues/5455

   When load CommitLog, CommitLog#load
   
![image](https://user-images.githubusercontent.com/15797831/199460763-ac17e88e-bfe7-4927-b9cf-ff383a4a3aef.png)
   
   The mappedFileQueue will execute checkSelf method, but this method return 
void.
   
![image](https://user-images.githubusercontent.com/15797831/199461139-10b8828d-7c33-49e5-a705-0c61e81d6622.png)
   if execute `if (cur.getFileFromOffset() - pre.getFileFromOffset() != 
this.mappedFileSize)`  condition, only print error log. Instead of break check 
and return false.
   **Is there a problem with this logic?**


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to