[rocketmq-clients] branch master updated: Define index of LoadBalancer as static (#272)

[aaronai]

This is an automated email from the ASF dual-hosted git repository.

aaronai pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/rocketmq-clients.git


The following commit(s) were added to refs/heads/master by this push:
     new 1056408  Define index of LoadBalancer as static (#272)
1056408 is described below

commit 105640858ae1d9c71e2055ce12f8bc55720c3286
Author: Aaron Ai <yangkun....@gmail.com>
AuthorDate: Tue Nov 1 11:07:17 2022 +0800

    Define index of LoadBalancer as static (#272)
---
 .../rocketmq/client/java/impl/consumer/SubscriptionLoadBalancer.java | 5 ++---
 .../rocketmq/client/java/impl/producer/PublishingLoadBalancer.java   | 5 ++---
 2 files changed, 4 insertions(+), 6 deletions(-)

diff --git 
a/java/client/src/main/java/org/apache/rocketmq/client/java/impl/consumer/SubscriptionLoadBalancer.java
 
b/java/client/src/main/java/org/apache/rocketmq/client/java/impl/consumer/SubscriptionLoadBalancer.java
index 012d441..b9b096e 100644
--- 
a/java/client/src/main/java/org/apache/rocketmq/client/java/impl/consumer/SubscriptionLoadBalancer.java
+++ 
b/java/client/src/main/java/org/apache/rocketmq/client/java/impl/consumer/SubscriptionLoadBalancer.java
@@ -34,14 +34,13 @@ public class SubscriptionLoadBalancer {
     /**
      * Index for round-robin.
      */
-    private final AtomicInteger index;
+    private static final AtomicInteger INDEX = new 
AtomicInteger(RandomUtils.nextInt(0, Integer.MAX_VALUE));
     /**
      * Message queues to receive message.
      */
     private final ImmutableList<MessageQueueImpl> messageQueues;
 
     public SubscriptionLoadBalancer(TopicRouteData topicRouteData) {
-        this.index = new AtomicInteger(RandomUtils.nextInt(0, 
Integer.MAX_VALUE));
         final List<MessageQueueImpl> mqs = 
topicRouteData.getMessageQueues().stream()
             .filter((Predicate<MessageQueueImpl>) mq -> 
mq.getPermission().isReadable() &&
                 Utilities.MASTER_BROKER_ID == mq.getBroker().getId())
@@ -53,7 +52,7 @@ public class SubscriptionLoadBalancer {
     }
 
     public MessageQueueImpl takeMessageQueue() {
-        final int next = index.getAndIncrement();
+        final int next = INDEX.getAndIncrement();
         return messageQueues.get(IntMath.mod(next, messageQueues.size()));
     }
 }
diff --git 
a/java/client/src/main/java/org/apache/rocketmq/client/java/impl/producer/PublishingLoadBalancer.java
 
b/java/client/src/main/java/org/apache/rocketmq/client/java/impl/producer/PublishingLoadBalancer.java
index feb9616..2c9597e 100644
--- 
a/java/client/src/main/java/org/apache/rocketmq/client/java/impl/producer/PublishingLoadBalancer.java
+++ 
b/java/client/src/main/java/org/apache/rocketmq/client/java/impl/producer/PublishingLoadBalancer.java
@@ -43,14 +43,13 @@ public class PublishingLoadBalancer {
     /**
      * Index for round-robin.
      */
-    private final AtomicInteger index;
+    private static final AtomicInteger INDEX = new 
AtomicInteger(RandomUtils.nextInt(0, Integer.MAX_VALUE));
     /**
      * Message queues to send message.
      */
     private final ImmutableList<MessageQueueImpl> messageQueues;
 
     public PublishingLoadBalancer(TopicRouteData topicRouteData) {
-        this.index = new AtomicInteger(RandomUtils.nextInt(0, 
Integer.MAX_VALUE));
         final List<MessageQueueImpl> mqs = 
topicRouteData.getMessageQueues().stream()
             .filter((Predicate<MessageQueueImpl>) mq -> 
mq.getPermission().isWritable() &&
                 Utilities.MASTER_BROKER_ID == mq.getBroker().getId())
@@ -68,7 +67,7 @@ public class PublishingLoadBalancer {
     }
 
     public List<MessageQueueImpl> takeMessageQueues(Set<Endpoints> excluded, 
int count) {
-        int next = index.getAndIncrement();
+        int next = INDEX.getAndIncrement();
         List<MessageQueueImpl> candidates = new ArrayList<>();
         Set<String> candidateBrokerNames = new HashSet<>();