This is an automated email from the ASF dual-hosted git repository. aaronai pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/rocketmq-clients.git
The following commit(s) were added to refs/heads/master by this push: new 6395d04 Fix typos (#128) 6395d04 is described below commit 6395d041ce9b60d0ca13a2aa512b1342030e6a8b Author: Aaron Ai <yangkun....@gmail.com> AuthorDate: Tue Aug 2 11:35:13 2022 +0800 Fix typos (#128) --- .github/workflows/license_checker.yaml | 2 +- .github/workflows/misspell_check.yaml | 2 +- cpp/proto/apache/rocketmq/v2/definition.proto | 2 +- cpp/source/rocketmq/ProducerImpl.cpp | 2 +- .../rocketmq-client-csharp/Protos/apache/rocketmq/v2/definition.proto | 2 +- docs/design.md | 4 ++-- docs/workflow.md | 2 +- golang/protocol/v2/definition.pb.go | 2 +- rust/proto/apache/rocketmq/v2/definition.proto | 2 +- 9 files changed, 10 insertions(+), 10 deletions(-) diff --git a/.github/workflows/license_checker.yaml b/.github/workflows/license_checker.yaml index 8377bfb..b17418d 100644 --- a/.github/workflows/license_checker.yaml +++ b/.github/workflows/license_checker.yaml @@ -1,4 +1,4 @@ -name: License checker +name: License Checker on: pull_request: types: [opened, reopened, synchronize] diff --git a/.github/workflows/misspell_check.yaml b/.github/workflows/misspell_check.yaml index 5c0404f..77411ac 100644 --- a/.github/workflows/misspell_check.yaml +++ b/.github/workflows/misspell_check.yaml @@ -9,8 +9,8 @@ jobs: misspell-check: runs-on: ubuntu-latest steps: - - name: Install misspell - uses: actions/checkout@v3 + - name: Install misspell run: | curl -L -o ./install-misspell.sh https://git.io/misspell sh ./install-misspell.sh diff --git a/cpp/proto/apache/rocketmq/v2/definition.proto b/cpp/proto/apache/rocketmq/v2/definition.proto index 86bb3dd..67e58b8 100644 --- a/cpp/proto/apache/rocketmq/v2/definition.proto +++ b/cpp/proto/apache/rocketmq/v2/definition.proto @@ -74,7 +74,7 @@ message ExponentialBackoff { } message CustomizedBackoff { - // To support classic backoff strategy which is arbitary defined by end users. + // To support classic backoff strategy which is arbitrary defined by end users. // Typical values are: `1s 5s 10s 30s 1m 2m 3m 4m 5m 6m 7m 8m 9m 10m 20m 30m 1h 2h` repeated google.protobuf.Duration next = 1; } diff --git a/cpp/source/rocketmq/ProducerImpl.cpp b/cpp/source/rocketmq/ProducerImpl.cpp index 64bbd18..7ad127c 100644 --- a/cpp/source/rocketmq/ProducerImpl.cpp +++ b/cpp/source/rocketmq/ProducerImpl.cpp @@ -548,7 +548,7 @@ TopicPublishInfoPtr ProducerImpl::getPublishInfo(const std::string& topic) { cv->Wait(mtx.get()); } - // TODO: propogate error_code to caller + // TODO: propagate error_code to caller return topic_publish_info; } diff --git a/csharp/rocketmq-client-csharp/Protos/apache/rocketmq/v2/definition.proto b/csharp/rocketmq-client-csharp/Protos/apache/rocketmq/v2/definition.proto index 21a6321..684cade 100644 --- a/csharp/rocketmq-client-csharp/Protos/apache/rocketmq/v2/definition.proto +++ b/csharp/rocketmq-client-csharp/Protos/apache/rocketmq/v2/definition.proto @@ -74,7 +74,7 @@ message ExponentialBackoff { } message CustomizedBackoff { - // To support classic backoff strategy which is arbitary defined by end users. + // To support classic backoff strategy which is arbitrary defined by end users. // Typical values are: `1s 5s 10s 30s 1m 2m 3m 4m 5m 6m 7m 8m 9m 10m 20m 30m 1h 2h` repeated google.protobuf.Duration next = 1; } diff --git a/docs/design.md b/docs/design.md index b7cabee..e38d2d4 100644 --- a/docs/design.md +++ b/docs/design.md @@ -10,7 +10,7 @@ We assume that you are familiar with the basic concepts and terminologies about In order to adapt different scenarios, we defined different types for messages to publish. -* **FIFO**(First In, First Out): follows standard [FIFO](https://en.wikipedia.org/wiki/FIFO) semantics, this type of message must set the `message group`. This type of message need to be used with FIFO consumer group, which gurantees that the message must be received first if the it is published first with the same message group. +* **FIFO**(First In, First Out): follows standard [FIFO](https://en.wikipedia.org/wiki/FIFO) semantics, this type of message must set the `message group`. This type of message need to be used with FIFO consumer group, which guarantees that the message must be received first if the it is published first with the same message group. * **DELAY**: the message about to be sent is not immediately visible to the consumer, this type of message must set the `delivery timestamp`, which decides the visible time to consumers; * **TRANSACTIONAL**: wrap the publishing of one or more messages into a transaction, provide commit/rollback method to decide the visibility of messages; * **NORMAL**: default type. The message type is NORMAL if it does not belong to the other types above. @@ -25,7 +25,7 @@ The different types are mutually exclusive, when means that the message to publi As we all know, consumer group is the basic unit of load balancing for consumers. Messages are evenly distributed to all consumers in the same consumer group. Now, we assigned more attributes to consumer group rather than the consumer itself. -* Consume timeout: maximum time window bewteen receiving messages and returning an response of acknowledgement. Message will be visible again if time runs out. +* Consume timeout: maximum time window between receiving messages and returning an response of acknowledgement. Message will be visible again if time runs out. * FIFO consumption switch: enable/disable FIFO consumption for FIFO messages. * Message consumption retry policy: decide the max delivery times and backoff algorithm for the message which is failed to be consumed in push consumer. diff --git a/docs/workflow.md b/docs/workflow.md index 3fe0eb9..9344f41 100644 --- a/docs/workflow.md +++ b/docs/workflow.md @@ -22,7 +22,7 @@ In details, the **server-client telemetry** provides a channel to upload the loc The client performs same tasks periodically. * Update topic route data and cache it. The subsequent request could get route from cache directly. -* Send heartbeart to keep alive. +* Send heartbeat to keep alive. * Send **server-client telemetry** request. Client settings may be overwritten by telemetry response. <div align="center"> diff --git a/golang/protocol/v2/definition.pb.go b/golang/protocol/v2/definition.pb.go index ddca2d0..b97021c 100644 --- a/golang/protocol/v2/definition.pb.go +++ b/golang/protocol/v2/definition.pb.go @@ -1012,7 +1012,7 @@ type CustomizedBackoff struct { sizeCache protoimpl.SizeCache unknownFields protoimpl.UnknownFields - // To support classic backoff strategy which is arbitary defined by end users. + // To support classic backoff strategy which is arbitrary defined by end users. // Typical values are: `1s 5s 10s 30s 1m 2m 3m 4m 5m 6m 7m 8m 9m 10m 20m 30m 1h 2h` Next []*durationpb.Duration `protobuf:"bytes,1,rep,name=next,proto3" json:"next,omitempty"` } diff --git a/rust/proto/apache/rocketmq/v2/definition.proto b/rust/proto/apache/rocketmq/v2/definition.proto index 86bb3dd..67e58b8 100644 --- a/rust/proto/apache/rocketmq/v2/definition.proto +++ b/rust/proto/apache/rocketmq/v2/definition.proto @@ -74,7 +74,7 @@ message ExponentialBackoff { } message CustomizedBackoff { - // To support classic backoff strategy which is arbitary defined by end users. + // To support classic backoff strategy which is arbitrary defined by end users. // Typical values are: `1s 5s 10s 30s 1m 2m 3m 4m 5m 6m 7m 8m 9m 10m 20m 30m 1h 2h` repeated google.protobuf.Duration next = 1; }