merlimat opened a new pull request, #25319:
URL: https://github.com/apache/pulsar/pull/25319
### Motivation
Follow-up cleanup for PIP-457 (V1 topic name and namespace removal, #25275
and #25304).
With V1 namespace removal, `NamespaceName.isGlobal()` always returns `true`
(since all namespaces are now 2-part V2 format). This makes `isGlobal()` dead
code — every condition checking it is either always-true or always-false.
### Modifications
- Removed `NamespaceName.isGlobal()` and `TopicName.isGlobal()` methods
- Simplified all call sites across the broker:
- Always-true `if (x.isGlobal())` conditions: unwrapped to just the body
- Always-false `if (!x.isGlobal())` conditions: removed as dead code
- Combined conditions: removed the `isGlobal()` term
- Cleaned up `PersistentTopicsBase.java`: chained `thenCompose()` calls
directly instead of using intermediate variables with block lambdas (~30
methods simplified)
### Verifying this change
This change is a pure refactor with no behavioral change — `isGlobal()`
already returned `true` unconditionally.
### Documentation
- [ ] `doc`
- [ ] `doc-required`
- [x] `doc-not-needed`
- [ ] `doc-complete`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
