BewareMyPower commented on code in PR #551:
URL: https://github.com/apache/pulsar-client-cpp/pull/551#discussion_r2922845995
##########
lib/ExecutorService.h:
##########
@@ -62,7 +66,19 @@ class PULSAR_PUBLIC ExecutorService : public
std::enable_shared_from_this<Execut
TcpResolverPtr createTcpResolver();
// throws std::runtime_error if failed
DeadlineTimerPtr createDeadlineTimer();
- void postWork(std::function<void(void)> task);
+
+ // Execute the task in the event loop thread asynchronously, i.e. the task
will be put in the event loop
+ // queue and executed later.
+ template <typename T>
+ void postWork(T &&task) {
+ ASIO::post(io_context_, std::forward<T>(task));
+ }
Review Comment:
It's not an issue, this class should not be `PULSAR_PUBLIC`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
