frankgrimes97 opened a new pull request, #663:
URL: https://github.com/apache/pulsar-helm-chart/pull/663
Fixes #662
### Motivation
ShellCheck flagged a number of issues with the Bash scripts some of which
could lead to unexpected behaviour.
e.g.
```
In scripts/pulsar/prepare_helm_release.sh line 21:
CHART_HOME=$(unset CDPATH && cd $(dirname "${BASH_SOURCE[0]}")/../.. && pwd)
^----------------------------^ SC2046
(warning): Quote this to prevent word splitting.
```
### Modifications
I've attempted to address most of the issues reported by ShellCheck `0.11.0`.
For other seeming false positives I suppressed them using [ShellCheck ignore
directives](https://github.com/koalaman/shellcheck/wiki/Ignore)
e.g. https://www.shellcheck.net/wiki/SC2016
```
$ grep shellcheck -A1 .ci/helm.sh
# shellcheck disable=SC2034
KIND_BIN=$OUTPUT_BIN/kind
--
# shellcheck disable=SC2016
timeout 120s "${KUBECTL}" exec -n "${NAMESPACE}"
"${CLUSTER}"-toolset-0 -- bash -c 'until [ "$(curl -s -L
http://pulsar-ci-broker:8080/status.html)" == "OK" ]; do sleep 3; done' || {
echo >&2 "Timeout waiting..."; ci::print_pod_logs; exit 1; }
```
### Verifying this change
I'm not sure how exhaustively these scripts are covered by CI tests and
haven't manually tested all of them due to my lack of familiarity with the
project so some assistance there would likely be needed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
