BewareMyPower commented on PR #24554: URL: https://github.com/apache/pulsar/pull/24554#issuecomment-3338779929
@Shawyeok Could you open discussion in mail list so that more people will see it? I think it's an issue with the compatibility with the semantic of `getPartitionedTopicMetadata` after PIP-344, not only this PR. Client 4.x should have the same issue. IMO, the code here https://github.com/apache/pulsar/blob/1050f48035c97a14094b812467f046f6d37ff6f4/pulsar-client/src/main/java/org/apache/pulsar/client/impl/BinaryProtoLookupService.java#L301-L308 should be changed to something like: ```java ByteBuf request; if (clientCnx.isSupportsGetPartitionedMetadataWithoutAutoCreation()) { request = Commands.newPartitionMetadataRequest(topicName.toString(), requestId, metadataAutoCreationEnabled); } else { request = Commands.newPartitionMetadataRequest(topicName.toString(), requestId); } ``` ```java public static ByteBuf newPartitionMetadataRequest(String topic, long requestId) { BaseCommand cmd = localCmd(Type.PARTITIONED_METADATA); cmd.setPartitionMetadata() .setTopic(topic) .setRequestId(requestId); return serializeWithSize(cmd); } ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
