lhotari opened a new pull request, #24787:
URL: https://github.com/apache/pulsar/pull/24787

   ### Motivation
   
   When brokers are exposed directly to clients, there might be a need to make 
the `advertisedAddress` absolute so that clients with unoptimal ndots 
configuration won't do unnecessary DNS lookups on the client side when an 
`advertisedAddress` with less dots than ndots is returned to the client from 
topic lookup.
   
   ### Modifications
   
   - remove extra dot from brokerId so that the brokerId format doesn't change 
when advertisedAddress is made absolute
   - add tests for brokerId
   - add integration tests to ensure that client can connect when TLS is 
enabled. This ensures that TLS hostname validation doesn't fail with the extra 
trailing dot.
   
   ### Documentation
   
   <!-- DO NOT REMOVE THIS SECTION. CHECK THE PROPER BOX ONLY. -->
   
   - [ ] `doc` <!-- Your PR contains doc changes. -->
   - [ ] `doc-required` <!-- Your PR changes impact docs and you will update 
later -->
   - [x] `doc-not-needed` <!-- Your PR changes do not impact docs -->
   - [ ] `doc-complete` <!-- Docs have been already added -->


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to