thomas-bousquet opened a new pull request, #1425:
URL: https://github.com/apache/pulsar-client-go/pull/1425
### Motivation
The admin client does not carry / accept the context `context.Context`.
Accepting a context as a first parameter is Go idiom, and can be useful when a
consumer wants to set a request timeout instead of tracking manually a timeout
with separate goroutine.
### Modifications
In order to accept that context and make this a non-breaking change, a
`WithContext()` method equivalent is added to each of the methods in the admin
client. Existing methods are now calling internally the `WithContext` method,
with a `context.Background()` for the required context.
### Verifying this change
This change can be verified with existing E2E tests on the admin client for
regression.
### Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): no
- The public API: no
- The schema: no
- The default values of configurations: no
- The wire protocol: no
### Documentation
- Does this pull request introduce a new feature? no
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
