BewareMyPower commented on PR #24745:
URL: https://github.com/apache/pulsar/pull/24745#issuecomment-3310451090

   > Since the fix for Java 17 will be released in 17.0.17 on October 21st, it 
will soon be addressed.
   
   I saw this comment just now, it should be fine to wait for the JDK patch, so 
I dismissed my approval.
   
   Using a dedicated executor is reasonable. But the `ThreadPoolExecutor` based 
executor is not better than ForkJoinPool, which uses work-stealing and is 
leveraged by the implementation of virtual threads. A simple difference is that 
if a task takes too long to complete, the queued tasks in the same thread don't 
have a chance to execute.
   
   `ForkJoinPool` is a better choice for independent tasks like those tasks to 
avoid blocking Netty IO threads or the Metadata store thread in Pulsar.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to