Copilot commented on code in PR #1422:
URL: https://github.com/apache/pulsar-client-go/pull/1422#discussion_r2340122118
##########
pulsar/producer_partition.go:
##########
@@ -1239,7 +1247,7 @@ func (p *partitionProducer) updateMetaData(sr
*sendRequest) {
if !sr.sendAsBatch {
// update sequence id for metadata, make the size of
msgMetadata more accurate
// batch sending will update sequence ID in the BatchBuilder
- p.updateMetadataSeqID(sr.mm, sr.msg)
+ p.updateMetadataSeqID(sr.mm, sr.msg) // We shouldn't update the
seq ID here!
Review Comment:
This TODO-style comment should be removed or replaced with a proper
explanation. If this is truly incorrect behavior, it should be fixed rather
than left with a confusing comment.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
