BewareMyPower commented on code in PR #24741:
URL: https://github.com/apache/pulsar/pull/24741#discussion_r2348462048
##########
pulsar-broker/src/main/java/org/apache/pulsar/broker/service/persistent/PersistentDispatcherSingleActiveConsumer.java:
##########
@@ -458,29 +454,26 @@ protected Pair<Integer, Long> calculateToRead(Consumer
consumer) {
return Pair.of(messagesToRead, bytesToRead);
}
- @Override
- public void readEntriesFailed(ManagedLedgerException exception, Object
ctx) {
- executor.execute(() -> internalReadEntriesFailed(exception, ctx));
- }
-
- private synchronized void internalReadEntriesFailed(ManagedLedgerException
exception, Object ctx) {
+ @VisibleForTesting
+ public synchronized Void readEntriesFailed(Throwable throwable, Consumer
consumer) {
Review Comment:
It makes sense. `whenComplete` combined with an `exceptionally` similar to
`catch (Throwable)` might be good here, let me revisit the code later
##########
pulsar-broker/src/main/java/org/apache/pulsar/broker/service/persistent/PersistentDispatcherSingleActiveConsumer.java:
##########
@@ -458,29 +454,26 @@ protected Pair<Integer, Long> calculateToRead(Consumer
consumer) {
return Pair.of(messagesToRead, bytesToRead);
}
- @Override
- public void readEntriesFailed(ManagedLedgerException exception, Object
ctx) {
- executor.execute(() -> internalReadEntriesFailed(exception, ctx));
- }
-
- private synchronized void internalReadEntriesFailed(ManagedLedgerException
exception, Object ctx) {
+ @VisibleForTesting
+ public synchronized Void readEntriesFailed(Throwable throwable, Consumer
consumer) {
Review Comment:
It makes sense. `whenCompleteAsyn` combined with an `exceptionally` similar
to `catch (Throwable)` might be good here, let me revisit the code later
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
