zhaizhibo commented on PR #24685: URL: https://github.com/apache/pulsar/pull/24685#issuecomment-3263435413
> Thanks for the contribution @zhaizhibo. > > LGTM, but please add a PIP to document this new feature. LLM can assist with that when you give the [PIP instructions](https://github.com/apache/pulsar/blob/master/pip/README.md), [template](https://github.com/apache/pulsar/blob/master/pip/TEMPLATE.md), this PR diff (https://github.com/apache/pulsar/pull/24685.patch, save as .txt file), PR description and a sample PIP as context (for example [PIP-379](https://github.com/apache/pulsar/blob/master/pip/pip-379.md), [PIP-428](https://github.com/apache/pulsar/blob/master/pip/pip-428.md) & [PIP-430](https://github.com/apache/pulsar/blob/master/pip/pip-430.md) are some of my PIPs). It's a bit similar as what I've documented for PR descriptions in https://gist.github.com/lhotari/81f533af4b9ad515e02d96e543c4408b . With this approach, you'll get 90% of the PIP written automatically and you just need to do the final edits. Thanks for the review, I will add the PIP document for this new feature and submit it for review soon. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
