oneby-wang commented on PR #24698: URL: https://github.com/apache/pulsar/pull/24698#issuecomment-3252160898
Hi, @lhotari there is a test failure in [Pulsar CI / CI - Unit - Pulsar Client (pull_request)](https://github.com/apache/pulsar/actions/runs/17453872406/job/49565356595?pr=24698), I think the problem is `TopicListWatcher.connectionFailed()` method doesn't have a dealineTime or maxRetryCount. If PulsarClient connection is closed, `watcherFuture` will never complete. https://github.com/apache/pulsar/blob/2e6a8eb1f200ca687064058a101963713b896fe2/pulsar-client/src/main/java/org/apache/pulsar/client/impl/TopicListWatcher.java#L92-L107 I read the source code of ConsumerImpl.connectionFailed() method, and I prepare to use `this.lookupDeadline = System.currentTimeMillis() + client.getConfiguration().getLookupTimeoutMs();` as `watcherFuture`'s deadline. I think it is reasonable, because TopicListWatcher and TopicLookup are kind of same things. https://github.com/apache/pulsar/blob/2e6a8eb1f200ca687064058a101963713b896fe2/pulsar-client/src/main/java/org/apache/pulsar/client/impl/ConsumerImpl.java#L1123-L1151 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
