lhotari commented on code in PR #24692:
URL: https://github.com/apache/pulsar/pull/24692#discussion_r2315029333
##########
docker/pulsar/build-scripts/remove-unnecessary-native-binaries.sh:
##########
@@ -41,9 +41,13 @@ unzip $ROCKSDB_JAR > /dev/null
if [ "$ARCH" = "x86_64" ]
then
- ROCKSDB_TO_KEEP=linux64-musl
+ ROCKSDB_TO_KEEP=linux64
else
- ROCKSDB_TO_KEEP=linux-$ARCH-musl
+ ROCKSDB_TO_KEEP=linux-$ARCH
+fi
+
+if [ "$1" != "glibc" ]; then
+ ROCKSDB_TO_KEEP="${ROCKSDB_TO_KEEP}-musl"
Review Comment:
There's no need for the arch check here. This appends `-musl` to
`ROCKSDB_TO_KEEP` unless `glibc` is passed as the first argument to the script.
This is to retain the previous behavior while supporting build of `glibc` based
image.
In `Dockerfile.wolfi`, it will call this script with `glibc` parameter.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
