lhotari commented on PR #24680:
URL: https://github.com/apache/pulsar/pull/24680#issuecomment-3234918746
@poorbarcode I merged origin/branch-4.0 and fixed checkstyle, but there
seems to be remaining issues:
```
[ERROR] Failures:
[ERROR]
org.apache.pulsar.client.api.PartitionCreationTest.testCreateConsumerForPartitionedTopicUpdateWhenDisableTopicAutoCreation
[INFO] Run 1: PASS
[ERROR] Run 2:
PartitionCreationTest.testCreateConsumerForPartitionedTopicUpdateWhenDisableTopicAutoCreation:126
» Conflict This topic already exists
[INFO]
[ERROR]
PartitionCreationTest.testCreateConsumerForPartitionedTopicWhenDisableTopicAutoCreation:65
» Conflict This topic already exists
[ERROR]
PartitionCreationTest.testCreateConsumerForPartitionedTopicWhenDisableTopicAutoCreation:65
» Conflict This topic already exists
[ERROR]
PartitionCreationTest.testCreateConsumerForPartitionedTopicWhenEnableTopicAutoCreation:94
» Conflict This topic already exists
[ERROR]
PartitionCreationTest.testCreateConsumerForPartitionedTopicWhenEnableTopicAutoCreation:94
» Conflict This topic already exists
[ERROR] PartitionCreationTest.testCreateMissedPartitions:161 expected
[null] but found [ConsumerBase{subscription='sub-1', consumerName='BIQ3d',
topic='testCreateMissedPartitions-useRestApi-false'}]
[ERROR] PartitionCreationTest.testCreateMissedPartitions:161 expected
[null] but found [ConsumerBase{subscription='sub-1', consumerName='Yn4Sn',
topic='testCreateMissedPartitions-useRestApi-true'}]
[INFO]
[ERROR] Tests run: 18, Failures: 7, Errors: 0, Skipped: 6
```
Regarding checkstyle, I recommend to configure IntelliJ with the checkstyle
plugin and Pulsar codestyle as explained in
https://pulsar.apache.org/contribute/setup-ide/#configure-checkstyle since it
will help avoid checkstyle errors.
Before pushing, it's useful to compile and run checkstyle, this is very
quick:
```shell
mvn -Pcore-modules,-main -T 1C clean install -DskipTests
-Dspotbugs.skip=true -DnarPluginPhase=none
```
to just run license check and checkstyle for all modules, this is the go to
command:
```shell
mvn -T 1C initialize license:check checkstyle:check
```
this runs very quickly for the complete project. Creating shell aliases for
these commands is helpful.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
