lhotari commented on code in PR #24665:
URL: https://github.com/apache/pulsar/pull/24665#discussion_r2303434927
##########
pulsar-metadata/src/main/java/org/apache/pulsar/metadata/impl/ZKMetadataStore.java:
##########
@@ -482,6 +482,31 @@ public void close() throws Exception {
}
}
+ @Override
+ public CompletableFuture<List<String>> getChildrenFromStore(String path) {
+ CompletableFuture<List<String>> cb = new CompletableFuture<>();
+ zkc.sync(path, (rc1, path1, ctx1) -> {
Review Comment:
Just wondering if we'd like to do `sync` before each and every
`getChildrenFromStore` call? That would cause significant performance
implications to the current behavior. Keeping the operations separate would let
to choose when it's needed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
