crossoverJie commented on code in PR #1409:
URL: https://github.com/apache/pulsar-client-go/pull/1409#discussion_r2299901042
##########
.github/workflows/ci.yml:
##########
@@ -53,7 +53,7 @@ jobs:
- uses: actions/checkout@v3
- name: Check for Docker images
id: check_images
- run: echo "::set-output name=images::$(docker images -q | wc -l)"
+ run: echo "{name}={images::$(docker images -q | wc -l)}" >>
$GITHUB_OUTPUT
Review Comment:
> Side note: This step in GitHub Actions CI is not very useful in the first
place since I assume that there would always be some pre-existing images. In
any case, the initial state in GitHub Actions CI is the same each time, so it
doesn't make much sense to have condition logic like this.
I also agree that the "`Clean Docker cache if images exist`" job has never
been executed. maybe this job can be deleted.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
