hrzzzz opened a new pull request, #24621:
URL: https://github.com/apache/pulsar/pull/24621
### Motivation
In the `org.apache.pulsar.metadata.impl.ZKMetadataStore` class, during
initialization and upon receiving the `SessionReestablished` event from
ZooKeeper, a watcher is registered using the following code:
```java
zkc.addWatch("/", this::handleWatchEvent, AddWatchMode.PERSISTENT_RECURSIVE,
(rc, path, ctx) -> {
// ...
}, null);
```
The use of `this::handleWatchEvent` here causes the watcher passed to the
`addWatch` method not to be the same object each time, which may lead to
duplicate registrations.
### Modifications
Use the same watcher object when calling the `addWatch` method
### Verifying this change
- [ ] Make sure that the change passes the CI checks.
- Added test in
`org.apache.pulsar.metadata.ZKSessionTest#testNoDuplicateWatcherRegistrationAfterSessionReestablished`
### Does this pull request potentially affect one of the following parts:
<!-- DO NOT REMOVE THIS SECTION. CHECK THE PROPER BOX ONLY. -->
*If the box was checked, please highlight the changes*
- [ ] Dependencies (add or upgrade a dependency)
- [ ] The public API
- [ ] The schema
- [ ] The default values of configurations
- [ ] The threading model
- [ ] The binary protocol
- [ ] The REST endpoints
- [ ] The admin CLI options
- [ ] The metrics
- [ ] Anything that affects deployment
### Documentation
<!-- DO NOT REMOVE THIS SECTION. CHECK THE PROPER BOX ONLY. -->
- [ ] `doc` <!-- Your PR contains doc changes. -->
- [ ] `doc-required` <!-- Your PR changes impact docs and you will update
later -->
- [x] `doc-not-needed` <!-- Your PR changes do not impact docs -->
- [ ] `doc-complete` <!-- Docs have been already added -->
### Matching PR in forked repository
PR in forked repository: https://github.com/hrzzzz/pulsar/pull/16
<!--
After opening this PR, the build in apache/pulsar will fail and instructions
will
be provided for opening a PR in the PR author's forked repository.
apache/pulsar pull requests should be first tested in your own fork since
the
apache/pulsar CI based on GitHub Actions has constrained resources and quota.
GitHub Actions provides separate quota for pull requests that are executed
in
a forked repository.
The tests will be run in the forked repository until all PR review comments
have
been handled, the tests pass and the PR is approved by a reviewer.
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
