coderzc commented on PR #24617: URL: https://github.com/apache/pulsar/pull/24617#issuecomment-3177813894
> @coderzc For `AvroSchemaTest.testTimestampWithJsonDef`, in Avro 1.11.4, it use `Unsafe.putObject(object, offset, value)` to set the object value when decoding. But in 1.12.0, it changed to use `Field.set(object, value)`, the later one could check the object type, so it could throw below error > > ``` > Can not set java.time.Instant field org.apache.pulsar.client.impl.schema.AvroSchemaTest$TimestampPojo.value to java.lang.Long > ``` > > can we delete this assertion, as it may not involve break changes ? > > https://github.com/apache/pulsar/blob/277835a65dd586de941b7d0ad448843b7b5589a4/pulsar-client/src/test/java/org/apache/pulsar/client/impl/schema/AvroSchemaTest.java#L510-L517 I think we can delete this assertion, this should be a misuse, If you want to customize the conversion, you can set the classLoader. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
