3pacccccc commented on PR #24610: URL: https://github.com/apache/pulsar/pull/24610#issuecomment-3170888543
> Btw. Not directly related to this PR, but could you check if there's any use for the PulsarClientException.InvalidMessageException that is thrown? Does it get used at all? I think that we have made changes to closing of the consumer, that it will fail all pending operations with PulsarClientException.AlreadyClosedException. Hi, lari, @lhotari I've checked all the InvalidMessageException usages: - mostly on the producer side (which isn't related to our current changes) - few nn the consumer side (mainly for message validation purposes) The current usage looks correct and doesn't need modification. However, I did notice and fix some inaccurate javadocs - please take a look when you have time. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
